Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ad-api): add door control #415

Merged
merged 9 commits into from
Jul 14, 2023

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jul 3, 2023

Description

Add the door control API. Close autowarefoundation/autoware#3232.
https://autowarefoundation.github.io/autoware-documentation/pr-415/design/autoware-interfaces/ad-api/features/vehicle-doors/

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Jul 3, 2023
@isamu-takagi isamu-takagi added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-415/
Modified URLs:

@isamu-takagi
Copy link
Contributor Author

isamu-takagi commented Jul 3, 2023

Wait for #407 -> merged.

@mitsudome-r mitsudome-r self-requested a review July 5, 2023 06:56
@mitsudome-r
Copy link
Member

It seems like DCO check is failing. Could you fix the unsigned commit?

@isamu-takagi isamu-takagi merged commit 3c15827 into autowarefoundation:main Jul 14, 2023
7 of 8 checks passed
@isamu-takagi isamu-takagi deleted the feat/adapi-door-command branch July 14, 2023 07:49
alanmengg pushed a commit to alanmengg/autoware-documentation that referenced this pull request Aug 2, 2023
* add door command

Signed-off-by: Takagi, Isamu <[email protected]>

* add release status

Signed-off-by: Takagi, Isamu <[email protected]>

* Update docs/design/autoware-interfaces/templates/autoware-interface.jinja2

* update message name

Signed-off-by: Takagi, Isamu <[email protected]>

* feat: update description

Signed-off-by: Takagi, Isamu <[email protected]>

---------

Signed-off-by: Takagi, Isamu <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: guiping meng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create api for vehicle status
2 participants